[libcxx-commits] [PATCH] D72036: [libcxx] span: Cleanup includes

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists requested changes to this revision.
mclow.lists added a comment.
This revision now requires changes to proceed.

I'm fine with the other changes here, but not the `array` change.



================
Comment at: libcxx/include/span:148
+template <class _Tp, size_t _Sz>
+struct array;
 
----------------
Forward declaring `array` will lead to other problems down the road. 
Visibility problems. Which lead to ODR violations.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72036/new/

https://reviews.llvm.org/D72036