[libcxx-commits] [PATCH] D75243: [libc++] Build the dylib with C++17 to allow aligned new/delete

Eric Fiselier via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Feb 27 10:17:39 PST 2020


EricWF added a comment.

I'm find requiring C++17 to build the dylib, but I'm not sure everyone is?

What is the impact on our compiler support? Surely not all of the currently supported compilers provide -std=c++17?

I would say land this and see if anybody complains. Maybe add a #if `_LIBCPP_STD_VER < 17` in one of the source files to enforce this?
I'm not sure all the buildbots will tolerate this change, but I'm happy to upgrade or fix those up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75243/new/

https://reviews.llvm.org/D75243





More information about the libcxx-commits mailing list