[libcxx-commits] [PATCH] D74163: [demangler] Fix the parsing of long double literals for PowerPC and S390

[Hubert Tong via Phabricator via libcxx-commits]

hubert.reinterpretcast added a comment.

In D74163#1891408 <https://reviews.llvm.org/D74163#1891408>, @uweigand wrote:

> But then this patch must be incorrect, given that it does
>
>   return getDerived().template parseFloatingLiteral<long double>();
>   
>
> for **both** the 'e' and 'g' cases on Intel.    Now I guess it depends on how the file is compiled (with -mlong-double-80 or -mlong-double-128), but either way, one of the cases will be handled incorrectly.


Agreed. The addition of the 'g' handling for cases other than the specific platforms mentioned by the title for the patch is outside the intended scope and should probably be avoided.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74163/new/

https://reviews.llvm.org/D74163