[libcxx-commits] [PATCH] D68480: Implementation of C++20's P1135R6 for libcxx

Mon Feb 24 11:25:54 PST 2020

teemperor added inline comments.

================
Comment at: libcxx/include/module.modulemap:234
   }
+  module barrier {
+    header "barrier"
----------------
ldionne wrote:
> teemperor wrote:
> > Maybe I'm missing something here, but due to this submodule we are always parsing the barrier header even when building the module with a language standard < C++14. This means that everyone using C++11 is no longer able to use the 'std' Clang module after this commit. Is this intentional?
> No, this is not intentional. Sorry, there were several failures that needed fixing after committing this (failures that were impossible to notice without throwing the change at all the build bots) -- we're getting there.
No worries, pushed a fix in b61e83eb0e31c1e6006569b43bb98a61ff44ca4c

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68480/new/

https://reviews.llvm.org/D68480