[libcxx-commits] [libcxx] 07c559c - [libc++] Explain XFAILs with std::uncaught_exceptions test

[Louis Dionne via libcxx-commits]

Author: Louis Dionne
Date: 2020-02-20T18:04:30-05:00
New Revision: 07c559caef967cda9812ab7b6ab94c20748e6ac9

URL: https://github.com/llvm/llvm-project/commit/07c559caef967cda9812ab7b6ab94c20748e6ac9
DIFF: https://github.com/llvm/llvm-project/commit/07c559caef967cda9812ab7b6ab94c20748e6ac9.diff

LOG: [libc++] Explain XFAILs with std::uncaught_exceptions test

Added: 
    

Modified: 
    libcxx/test/std/language.support/support.exception/uncaught/uncaught_exceptions.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/std/language.support/support.exception/uncaught/uncaught_exceptions.pass.cpp b/libcxx/test/std/language.support/support.exception/uncaught/uncaught_exceptions.pass.cpp
index c498b5778bae..966e8c68ea49 100644
--- a/libcxx/test/std/language.support/support.exception/uncaught/uncaught_exceptions.pass.cpp
+++ b/libcxx/test/std/language.support/support.exception/uncaught/uncaught_exceptions.pass.cpp
@@ -9,13 +9,17 @@
 // UNSUPPORTED: libcpp-no-exceptions
 // XFAIL: libcpp-no-exceptions
 
-// XFAIL: macosx10.7
-// XFAIL: macosx10.8
-// XFAIL: macosx10.9
-// XFAIL: macosx10.10
-// XFAIL: macosx10.11
-// XFAIL: with_system_cxx_lib=macosx10.12
+// std::uncaught_exceptions() was introduced in the dylib on Mac OS 10.12
+// XFAIL: with_system_cxx_lib=macosx10.11
+// XFAIL: with_system_cxx_lib=macosx10.10
+// XFAIL: with_system_cxx_lib=macosx10.9
+// XFAIL: with_system_cxx_lib=macosx10.8
+// XFAIL: with_system_cxx_lib=macosx10.7
+
+// However, std::uncaught_exceptions() gives the wrong answer in Mac OS 10.12
+// and 10.13, where it only gives 0 or 1. This was fixed later.
 // XFAIL: with_system_cxx_lib=macosx10.13
+// XFAIL: with_system_cxx_lib=macosx10.12
 
 // test uncaught_exceptions