[libcxx-commits] [PATCH] D74885: [libcxx] Construct __start_std_streams at high init priority

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.
Herald added a subscriber: dexonsmith.

Also, please coordinate with @EricWF on https://reviews.llvm.org/D31413. I haven't followed the whole thing, but what are we blocked on? It seems like a fairly serious issue that's worth fixing.



================
Comment at: libcxx/src/iostream.cpp:83
+  || defined(_LIBCPP_COMPILER_MSVC)
+// GCC on Apple doesn't support the init priority attribute,
+// and MSVC doesn't support any GCC attributes.
----------------
Building the dylib on Apple isn't supported with GCC. It may happen to work, but that's not maintained. Please don't add a code path to support it -- it just makes things slightly more complex while giving a false impression of support.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74885/new/

https://reviews.llvm.org/D74885