[libcxx-commits] [PATCH] D68480: Implementation of C++20's P1135R6 for libcxx

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

Thanks a lot for all the work and patience, Olivier. I think we're good to go now. Do you have commit access?

Also, can you please confirm that you meant to introduce all the following new symbols in the dylib, and nothing else:

  std::__1::__libcpp_atomic_wait(std::__1::__cxx_atomic_impl<long long, std::__1::__cxx_atomic_base_impl<long long> > const volatile*, long long)
  std::__1::__libcpp_atomic_wait(void const volatile*, long long)
  std::__1::__cxx_atomic_notify_all(std::__1::__cxx_atomic_impl<long long, std::__1::__cxx_atomic_base_impl<long long> > const volatile*)
  std::__1::__cxx_atomic_notify_all(void const volatile*)
  std::__1::__cxx_atomic_notify_one(std::__1::__cxx_atomic_impl<long long, std::__1::__cxx_atomic_base_impl<long long> > const volatile*)
  std::__1::__cxx_atomic_notify_one(void const volatile*)
  std::__1::__libcpp_atomic_monitor(std::__1::__cxx_atomic_impl<long long, std::__1::__cxx_atomic_base_impl<long long> > const volatile*)
  std::__1::__libcpp_atomic_monitor(void const volatile*)
  std::__1::__arrive_barrier_algorithm_base(std::__1::__barrier_algorithm_base*, unsigned char)
  std::__1::__destroy_barrier_algorithm_base(std::__1::__barrier_algorithm_base*)
  std::__1::__construct_barrier_algorithm_base(long&)

Those will have to be added to the ABI list file (I can do that).


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68480/new/

https://reviews.llvm.org/D68480