[libcxx-commits] [PATCH] D69132: [libc++][P0784] Marked the default allocator constexpr.

[Michael Park via Phabricator via libcxx-commits]

mpark marked 4 inline comments as done and an inline comment as not done.
mpark added inline comments.


================
Comment at: libcxx/include/new:261
+  template <class _A1, class _A2>
+  static inline _LIBCPP_CONSTEXPR_AFTER_CXX17_WITH_CONSTEXPR_DYNAMIC_ALLOC
+  void __do_call(void *__ptr, _A1 __a1, _A2 __a2) {
----------------
ldionne wrote:
> I assume you had to move the `__do_call` functions here because making them `constexpr` somehow required their definition to appear above the definition of the various `__do_allocate` functions below?
That's correct.


================
Comment at: libcxx/test/std/utilities/memory/default.allocator/allocator.members/allocate.pass.cpp:83
+constexpr bool test_aligned_constexpr() {
+    typedef AlignedType<Align> T;
+    std::allocator<T> a;
----------------
ldionne wrote:
> You have a mismatch in the indentation of the return and body.
Yeah, I was following the formatting of many of tests. See `libcxx/test/std/utilities/memory/default.allocator/allocator_types.pass.cpp` for an example, but there are many others.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69132/new/

https://reviews.llvm.org/D69132