[libcxx-commits] [PATCH] D74163: [demangler] Fix the parsing of long double literals for PowerPC and S390

Hubert Tong via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Feb 10 11:23:19 PST 2020


hubert.reinterpretcast added a comment.

In D74163#1867589 <https://reviews.llvm.org/D74163#1867589>, @thakis wrote:

> Making this dependent on preprocessor defines means you can only demangle when the target binary matches the host binary. That doesn't seem like a feasible approach.


The patch here is following existing practice in the codebase. The targets binary versus host binary issue already exists with respect to `FloatData<long double>`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74163/new/

https://reviews.llvm.org/D74163





More information about the libcxx-commits mailing list