[libcxx-commits] [PATCH] D74341: [libc++][Apple] Use CLOCK_MONOTONIC_RAW instead of CLOCK_UPTIME_RAW for steady_clock

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 12 07:46:03 PST 2020


ldionne added a comment.

In D74341#1872286 <https://reviews.llvm.org/D74341#1872286>, @EricWF wrote:

> Can we assume that all supported Apple platforms have clock_gettime now? (It was added in 10.12)
>
> If so, can we remove the fallback?


I think it would be fine to remove the fallback, as the only thing that'll do is require macOS >= 10.12 in order to build the libc++ dylib. Since pretty much only vendors build the dylib, I think that's a reasonable thing to do. Will do in a followup patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74341/new/

https://reviews.llvm.org/D74341





More information about the libcxx-commits mailing list