[libcxx-commits] [PATCH] D72036: [libcxx] span: Cleanup includes

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 11 02:22:43 PST 2020


ldionne accepted this revision.
ldionne added a comment.

Looks like you implemented the requested changes, and this LGTM. Thanks!

FWIW, I'm favorable to the idea of having forward declaration headers, however I think we have a lot of work to do before this makes sense, like splitting up the header files containing definitions. I think I would like to see this done as a concentrated effort instead of ad-hoc patches.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72036/new/

https://reviews.llvm.org/D72036





More information about the libcxx-commits mailing list