[libcxx-commits] [PATCH] D72640: [libcxx] Qualify make_pair in searcher implementations to prevent ADL

Logan Smith via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Feb 6 12:15:20 PST 2020


logan-5 added a comment.

In D72640#1862239 <https://reviews.llvm.org/D72640#1862239>, @Quuxplusone wrote:

> @logan-5, you mentioned that you have found other cases of unintended ADL by applying the clang-tidy check in D72282 <https://reviews.llvm.org/D72282>, right? But those patches have not yet been uploaded to Phab? Is there any help I can offer that would advance that work?


Hi @Quuxplusone, thanks a lot for the ping. I did indeed promise more patches for more cases found by that clang-tidy check, but I haven't gotten a chance to implement them yet. I think I was waiting for this one to land completely for some reason.

I think I'll be able to get to it this weekend... unless somebody beats me to it. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72640/new/

https://reviews.llvm.org/D72640





More information about the libcxx-commits mailing list