[libcxx-commits] [PATCH] D74108: [libcxx] When merging archives, build index even on Darwin

[Petr Hosek via Phabricator via libcxx-commits]

phosek created this revision.
phosek added reviewers: ldionne, EricWF.
Herald added subscribers: libcxx-commits, arphaman, dexonsmith, christof.
Herald added a project: libc++.

We always want to build the table of contents. Additionally, we also
set the flag to make the output deterministic which is already the
default for llvm-ar.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74108

Files:
  libcxx/utils/merge_archives.py


Index: libcxx/utils/merge_archives.py
===================================================================
--- libcxx/utils/merge_archives.py
+++ libcxx/utils/merge_archives.py
@@ -143,10 +143,10 @@
 
     if args.use_libtool:
         files = [f for f in files if not f.startswith('__.SYMDEF')]
-        execute_command_verbose([libtool_exe, '-static', '-o', args.output] + files,
+        execute_command_verbose([libtool_exe, '-static', '-o', args.output, '-sD'] + files,
                                 cwd=temp_directory_root, verbose=args.verbose)
     else:
-        execute_command_verbose([ar_exe, 'rcs', args.output] + files,
+        execute_command_verbose([ar_exe, 'rcsD', args.output] + files,
                                 cwd=temp_directory_root, verbose=args.verbose)
 
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74108.242804.patch
Type: text/x-patch
Size: 792 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200206/643e94c9/attachment.bin>