[libcxx-commits] [PATCH] D73838: [libcxxabi] Fix layout of __cxa_exception for win64, fixing static assert failures

Sun Feb 2 11:02:26 PST 2020

mstorsjo added a comment.

In D73838#1853696 <https://reviews.llvm.org/D73838#1853696>, @rjmccall wrote:

> In D73838#1853694 <https://reviews.llvm.org/D73838#1853694>, @mstorsjo wrote:
>
> > In D73838#1853615 <https://reviews.llvm.org/D73838#1853615>, @rjmccall wrote:
> >
> > > > I presume this is a break for cases where an exception is thrown across libraries that have statically linked different versions of libcxxabi?
> > >
> > > You really aren't supposed to redundantly statically link libcxxabi like that; there are things in there that need to be unique.
> >
> >
> > Out of curiosity - which are these? Things like typeids not being unique, or are there things with global state as well?
>
>
> `typeid`s are the big thing, but there's global state associated with `__cxa_atexit`, thread-local variables, initialization guards, the terminate and unexpected handlers, and so on.

Right - ok, thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73838/new/

https://reviews.llvm.org/D73838