[libcxx-commits] [PATCH] D73584: [libcxxabi] Changed use of _Unwind_Personality_Fn to __personality_routine

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D73584#1853294 <https://reviews.llvm.org/D73584#1853294>, @mstorsjo wrote:

> In D73584#1853124 <https://reviews.llvm.org/D73584#1853124>, @zero9178 wrote:
>
> > Instead of changing the libunwind header to contain _Unwind_Personality_Fn, changed libcxxabi to use __personality_routine
>
>
> Hmm, this isn't quite the way I interpreted @compnerd's comment
>
> In D73584#1853050 <https://reviews.llvm.org/D73584#1853050>, @compnerd wrote:
>
> > Why not rename `__personality_routine` to `_Unwind_Personality_Fn`?  I don't think that `_Unwind_Personality_Fn` is part of either the ABI-EH, gABI, or PSABI, but, it is acceptable for GCC compatibility.
>
>
> I interpret this as suggesting changing the instances of `__personality_routine` to `_Unwind_Personality_Fn`, instead of adding a new typedef (as you did in the previous iteration of the patch).


... although I see that isn't easily doable, as libuwind is full of use of that type.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73584/new/

https://reviews.llvm.org/D73584