[libcxx-commits] [PATCH] D93815: [libc++] [P1065] Constexpr invoke, reference_wrapper, mem_fn, not_fn.

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver accepted this revision.
zoecarver added a comment.

This LGTM. Thanks. Looking forward to using this in my bind_front patch ;)



================
Comment at: libcxx/test/std/utilities/function.objects/func.invoke/invoke_constexpr.pass.cpp:269
+
+int main(int, char**) {
+    static_assert(bullet_one_two_tests());
----------------
I assume it didn't make sense to merge these with the existing tests because of functions like `foo` which would only work in one mode or the other? 

Is there any test coverage here that isn't in the non-constexpr version? If so, would it make sense to run these tests outside of a constexpr context as well (it very well might not)?


================
Comment at: libcxx/test/std/utilities/function.objects/func.not_fn/not_fn.pass.cpp:548
     { // test multi arg
+        using String = const char *;
         const double y = 3.14;
----------------
This is just because `std::string` isn't constexpr?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93815/new/

https://reviews.llvm.org/D93815