[libcxx-commits] [PATCH] D93074: [libc++] Split allocator_traits and pointer_traits out of <memory>

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Dec 22 05:21:10 PST 2020

Quuxplusone added inline comments.

Comment at: libcxx/include/__memory/allocator_traits.h:14
+#include <__config>
+#include <__memory/base.h>
+#include <__memory/pointer_traits.h>
ldionne wrote:
> miscco wrote:
> > Should this also be __base.h to make clear that these are purely internal headers?
> I've put the headers in a directory that had `__` in it to make it clear it was internal (and to avoid conflicting with user-provided directories as much as possible). I don't think it's necessary to have the file contain `__` too IMO.
FWIW, I just saw this today, and I wish the level of directory structure weren't there; I'd rather have seen `<__memory_base>`, `<__memory_pointer_traits>`, `<__memory_allocator_traits>`. I don't even know what's in `<__memory/utilities.h>`, so I probably wouldn't have split it out — just combine it into `<__memory_base>` if it's needed by lots of things, and otherwise leave it in `<memory>`.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list