[libcxx-commits] [PATCH] D93582: [libc++] [libc++abi] Correctly quote source and target names in tests. NFC.

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius added inline comments.


================
Comment at: libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp:16
 // Ensure locale-independence for unicode tests.
-// RUN: %{gdb} -nx -batch -iex "set autoload off" -ex "source %S/../../../utils/gdb/libcxx/printers.py" -ex "python register_libcxx_printer_loader()" -ex "source %S/gdb_pretty_printer_test.py" %t.exe
+// RUN: %{gdb} -nx -batch -iex "set autoload off" -ex "source %S/../../../utils/gdb/libcxx/printers.py" -ex "python register_libcxx_printer_loader()" -ex "source %S/gdb_pretty_printer_test.py" "%t.exe"
 
----------------
Mordante wrote:
> While you're at it, would it make sense to also guard `%{cxx}` and `%{gdb}`?
FYI, cxx was already correctly quoted. I added quoting to gdb. There are other issues in other parts of LLVM tho (e.g. one cannot build clang in a build dir with spaces) but I'll handle that in different patches.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93582/new/

https://reviews.llvm.org/D93582