[libcxx-commits] [PATCH] D93582: [libc++] [libc++abi] Correctly quote source and target names in tests. NFC.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Dec 20 04:59:39 PST 2020


Mordante added a comment.

One minor question, otherwise LGTM.



================
Comment at: libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp:16
 // Ensure locale-independence for unicode tests.
-// RUN: %{gdb} -nx -batch -iex "set autoload off" -ex "source %S/../../../utils/gdb/libcxx/printers.py" -ex "python register_libcxx_printer_loader()" -ex "source %S/gdb_pretty_printer_test.py" %t.exe
+// RUN: %{gdb} -nx -batch -iex "set autoload off" -ex "source %S/../../../utils/gdb/libcxx/printers.py" -ex "python register_libcxx_printer_loader()" -ex "source %S/gdb_pretty_printer_test.py" "%t.exe"
 
----------------
While you're at it, would it make sense to also guard `%{cxx}` and `%{gdb}`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93582/new/

https://reviews.llvm.org/D93582



More information about the libcxx-commits mailing list