[libcxx-commits] [PATCH] D91201: [libc++] LWG2070: Use Allocator construction for objects created with allocate_shared

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Dec 17 14:54:49 PST 2020


zoecarver added inline comments.


================
Comment at: libcxx/include/memory:2639
+        _LIBCPP_HIDE_FROM_ABI explicit _Storage(_Alloc&& __a) : __alloc_(_VSTD::move(__a)) { }
+        _LIBCPP_HIDE_FROM_ABI ~_Storage() { }
+        [[no_unique_address]] _Alloc __alloc_;
----------------
The above comment got me thinking... why can't this be a default destructor? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91201/new/

https://reviews.llvm.org/D91201



More information about the libcxx-commits mailing list