[libcxx-commits] [PATCH] D93383: [libc++] Use c++20 instead of c++2a consistently.

Marek Kurdej via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Dec 16 07:45:32 PST 2020

curdeius planned changes to this revision.
curdeius marked 2 inline comments as done.
curdeius added a comment.

In D93383#2457932 <https://reviews.llvm.org/D93383#2457932>, @mclow.lists wrote:

> You need to bump the `TEST_STD_VER` too - see test/support/test_macros.h

Will do.

Comment at: libcxx/utils/generate_feature_test_macro_components.py:659-662
 #if _LIBCPP_STD_VER > 17
miscco wrote:
> Are there already C++2b macros, should we already add this here, as we are effectively bumping the version?
I have another patch waiting that will add C++2b.

Comment at: libcxx/utils/generate_feature_test_macro_components.py:802
 #elif TEST_STD_VER > 17
miscco wrote:
> I guess technically this should now be `== 20`?
Right. I didn't want to change `TEST_STD_VER` before the next patch but that will be actually better. Anyway, it addresses Marshall's comment too.

Comment at: libcxx/utils/generate_feature_test_macro_components.py:806
 #endif // TEST_STD_VER > 17
miscco wrote:
> Should we already have something here for c++2b?
As said above. I'll add things in the next patch.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list