[libcxx-commits] [PATCH] D93383: [libc++] Use c++20 instead of c++2a consistently.

[Michael Schellenberger Costa via Phabricator via libcxx-commits]

miscco added a comment.

This looks great, I have some minor concerns regarding the next version and whether we should already prepare for that



================
Comment at: libcxx/utils/generate_feature_test_macro_components.py:659-662
 #if _LIBCPP_STD_VER > 17
-{cxx2a_macros}
+{cxx20_macros}
 #endif
 
----------------
Are there already C++2b macros, should we already add this here, as we are effectively bumping the version?


================
Comment at: libcxx/utils/generate_feature_test_macro_components.py:802
 
 #elif TEST_STD_VER > 17
 
----------------
I guess technically this should now be `== 20`?


================
Comment at: libcxx/utils/generate_feature_test_macro_components.py:806
 
 #endif // TEST_STD_VER > 17
 
----------------
Should we already have something here for c++2b?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93383/new/

https://reviews.llvm.org/D93383