[libcxx-commits] [PATCH] D93130: [libc++] Refactor allocate_shared to use an allocation guard

Tue Dec 15 08:45:33 PST 2020

saugustine added a comment.

In D93130#2455145 <https://reviews.llvm.org/D93130#2455145>, @ldionne wrote:

> In D93130#2453963 <https://reviews.llvm.org/D93130#2453963>, @saugustine wrote:
>
>> This change appears to have dropped a constructor, or maybe two. I'm not familiar enough with all the requirements to know if that is correct or not. Here is a somewhat redacted version of the errors I get building a private application.
>> ...
>
> Is it possible that your custom `Allocator` has its converting copy constructor (from other specializations of `Allocator`) marked as `explicit`? We don't seem to have a test for that, I'll add one and fix this, but please confirm that it's the case.

Yes, in fact it does. Thanks for the quick follow up.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93130/new/

https://reviews.llvm.org/D93130