[libcxx-commits] [PATCH] D92229: [libc++] Update clang-format configuration

Marek Kurdej via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Dec 15 01:06:40 PST 2020


curdeius added a comment.

Concerning the style itself, personally I'd go for a style that is as close to vanilla LLVM style as possible (except for things like disabling comment reflowing for tests, but I'd put this specific .clang-format config file into libcxx/test).
For the moment I'm waiting for the buildbots to be ready so that I can finish the build part.



================
Comment at: libcxx/.clang-format:5
 Language: Cpp
 Standard: Cpp03
 
----------------
Mordante wrote:
> Do we need to keep this at Cpp03? Changing this to newer versions of C++ will of course break code like 'std::vector<std::pair<int, int>>`. But this seems to break formatting the C++11 string literal prefixes: u8, u, U.
I'd love to remove Cpp03... But clang in c++03 mode gives error: `error: a space is required between consecutive right angle brackets (use '> >')`.
BTW, from clang-format documentation: "Cpp03 is a deprecated alias for c++03".
Personally I'd like to use `Standard: Latest`.
There's also `Standard: Auto`, that may be a compromise to use `> >` in c++03 sensitive code and `>>` elsewhere.

Ref: https://clang.llvm.org/docs/ClangFormatStyleOptions.html


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92229/new/

https://reviews.llvm.org/D92229



More information about the libcxx-commits mailing list