[libcxx-commits] [PATCH] D93166: [libc++][format] Add basic_format_parse_context.

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius added inline comments.


================
Comment at: libcxx/include/format:349
+	// behavior when id >= num_args_.
+    if (std::is_constant_evaluated() && __id >= __num_args_)
+      __format::__throw_error("Argument index outside the valid range");
----------------
FYI, your implementation seems to be exactly what the author meant (std branch is missing in the main fmt repo):
https://github.com/agmt/fmt/blob/std/include/format#L181-L199


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93166/new/

https://reviews.llvm.org/D93166