[libcxx-commits] [PATCH] D91137: [5/N] [libcxx] Convert paths to/from the right narrow code page for narrow strings on windows

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Dec 14 23:13:33 PST 2020

mstorsjo added inline comments.

Comment at: libcxx/include/filesystem:1467
+      "u8path(Iter, Iter) requires Iter have a value_type of type 'char'"
+      " or 'char8_t'"
ldionne wrote:
> I don't think `#ifdefing` the `static_assert` message adds anything. It just makes things harder to read IMO. I know this was done the same way elsewhere, but I think we should actually remove the ifdefs in those other places instead.
Fair enough, I can remove that bit from this patch, and I'll send a separate patch for removing the other ifdefs, and rebase these patches on top of that (where relevant) once that's merged.

Comment at: libcxx/src/filesystem/operations.cpp:21
+#if defined(_LIBCPP_WIN32API)
+#define WIN32_LEAN_AND_MEAN
+#define NOMINMAX
ldionne wrote:
> Please indent includes like:
> ```
> #if defined(_LIBCPP_WIN32API`
> #   define WIN32_LEAN_AND_MEAN
> #   include <stuff>
> #else
> #   include <more stuff>
> #endif
> ```
Ok, will change.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list