[libcxx-commits] [PATCH] D93153: [libc++] Consistently replace `::new(__p) T` with `::new ((void*)__p) T`. NFCI
Zoe Carver via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Dec 14 13:57:04 PST 2020
zoecarver added inline comments.
================
Comment at: libcxx/include/__functional_03:129
unique_ptr<__func, _Dp> __hold(__a.allocate(1), _Dp(__a, 1));
- ::new (__hold.get()) __func(__f_.first(), _Alloc(__a));
+ ::new ((void*)__hold.get()) __func(__f_.first(), _Alloc(__a));
return __hold.release();
----------------
Nit: would be better to make these `static_cast`s IMHO.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93153/new/
https://reviews.llvm.org/D93153
More information about the libcxx-commits
mailing list