[libcxx-commits] [PATCH] D93233: [libc++] Replaces std::sort by Bitset sorting algorithm.

[MinJae Hwang via Phabricator via libcxx-commits]

minjaehwang added inline comments.


================
Comment at: libcxx/test/libcxx/algorithms/sort.pass.cpp:21
+#ifndef _LIBCPP_VERSION
+#error _LIBCPP_VERSION not defined
+#endif
----------------
ldionne wrote:
> Shouldn't this test work with all implementations? Why not?
You are right. This is a general sort test. Will fix it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93233/new/

https://reviews.llvm.org/D93233