[libcxx-commits] [PATCH] D93166: [libc++][format] Add basic_format_parse_context.

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius added a comment.

I haven't finished reviewing. Will do soon.



================
Comment at: libcxx/include/format:349
+  iterator __end_;
+  enum _Indexing { __unknown, __manual, __automatic };
+  _Indexing __indexing_;
----------------
Mordante wrote:
> curdeius wrote:
> > Why not enum class?
> I didn't add it since the enum is only used internally in the class so I feel the `class` doesn't add to much benefits and http://eel.is/c++draft/format.parse.ctx doesn't require it.
> 
> If you feel strongly about it I don't mind changing it.
Don't bother. No strong feelings about this :).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93166/new/

https://reviews.llvm.org/D93166