[libcxx-commits] [PATCH] D93153: [libc++] Consistently replace `::new(__p) T` with `::new ((void*)__p) T`. NFCI

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D93153#2450776 <https://reviews.llvm.org/D93153#2450776>, @curdeius wrote:

> LGTM. This `__voidify` looks really strange indeed. Blame shows that it was added in https://github.com/llvm/llvm-project/commit/0724f8bf47f8cb073d41e2750d45d5b05e66bf0b by @ldionne.

TBH, I just implemented it in the most naive way possible, based on http://eel.is/c++draft/specialized.algorithms#general-4.

I'm not sure why we first cast to `const volatile void*` and then use `remove_const`, instead of just casting to `void volatile*`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93153/new/

https://reviews.llvm.org/D93153