[libcxx-commits] [PATCH] D93137: generate_header_tests.py: Sort the header files ASCIIbetically.

Marek Kurdej via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Dec 11 13:10:39 PST 2020


curdeius added a comment.

I thought that it should be git that takes care of line endings... Maybe .gitattributes aren't set correctly, or that was my settings that used CRLF (BTW, I use WSL under Windows so that may be the case).



================
Comment at: libcxx/utils/generate_header_tests.py:140
 
-    include_headers = glob.glob(pattern, recursive=False)
+    files = sorted([f for f in glob.glob(pattern, recursive=False)])
 
----------------
Doesn't that work? Glob returns a list (so an iterable, nope?).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93137/new/

https://reviews.llvm.org/D93137



More information about the libcxx-commits mailing list