[libcxx-commits] [PATCH] D92790: [libc++][P0053R7] Add <syncstream> header and implement std::basic_syncbuf

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/lib/abi/x86_64-unknown-linux-gnu.libcxxabi.v1.stable.exceptions.no_new_in_libcxx.abilist:35-43
+{'is_defined': False, 'name': '_ZTVSt9exception', 'size': 0, 'type': 'OBJECT'}
 {'is_defined': False, 'name': '_ZdaPv', 'type': 'FUNC'}
 {'is_defined': False, 'name': '_ZdaPvSt11align_val_t', 'type': 'FUNC'}
 {'is_defined': False, 'name': '_ZdlPv', 'type': 'FUNC'}
+{'is_defined': False, 'name': '_ZdlPvSt11align_val_t', 'type': 'FUNC'}
 {'is_defined': False, 'name': '_Znam', 'type': 'FUNC'}
 {'is_defined': False, 'name': '_ZnamSt11align_val_t', 'type': 'FUNC'}
----------------
curdeius wrote:
> abrachet wrote:
> > curdeius wrote:
> > > abrachet wrote:
> > > > Still not sure why these are here though.
> > > It all depends on your environment and link flags. Once CI gets triggered you'd be able to get updated ABI lists from artifacts on failed build steps (in Buildkite). You'll **probably** need to remove these unrelated changes (exception, align_val_t).
> > How does CI get triggered for libcxx? You mentioned it in a previous comment, but will that be only after pushing the changes?
> Ahhh, I think I know what may happen. How do you upload the patches? You don't use arcanist, do you?
> It seems that the problem when uploading patches through the web GUI is that it removes the set repository (rG LLVM Github Monorepo).
> @mstorsjo had the same problems, apparently updating the patch twice (and setting the repo in the middle) triggers the CI if I understood correctly.
> @ldionne, can we do something to fix that?
> @abrachet, can you try using arcanist (`arc`)? See https://www.llvm.org/docs/Phabricator.html?highlight=arcanist#id3
Yes - so far, it seems like if the patch already has the repo set, it still looks like it's set while updating the diff (and removing and readding it in the last step doesn't help), but after submitting, it's gone. So I guess one either has to explicitly remove the repo before updating a patch, or update it twice (so that one can re-set the repo the second time, to make CI pick it up again).

FWIW, I don't think the repo setting is something specific to the libcxx hooks, but sounds to me more like a phabricator issue.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92790/new/

https://reviews.llvm.org/D92790