[libcxx-commits] [PATCH] D92790: [libc++][P0053R7] Add <syncstream> header and implement std::basic_syncbuf

[Alex Brachet via Phabricator via libcxx-commits]

abrachet marked 6 inline comments as done.
abrachet added a comment.

Thanks a lot for the comments @curdeius



================
Comment at: libcxx/include/syncstream:14
+/*
+    syncstream synopsis
+
----------------
curdeius wrote:
> You should also update the synopsis of `<iosfwd>`. Cf. paragraph 3.2 of the paper.
Thanks, good catch


================
Comment at: libcxx/include/syncstream:64-98
+  template <class charT,
+            class traits,
+            class Allocator>
+  class basic_osyncstream
+    : public basic_ostream<charT, traits>
+  {
+  public:
----------------
curdeius wrote:
> I never know, should unimplemented parts be present in the synopsis? @ldionne?
I have removed them for now


================
Comment at: libcxx/lib/abi/x86_64-unknown-linux-gnu.libcxxabi.v1.stable.exceptions.no_new_in_libcxx.abilist:35-43
+{'is_defined': False, 'name': '_ZTVSt9exception', 'size': 0, 'type': 'OBJECT'}
 {'is_defined': False, 'name': '_ZdaPv', 'type': 'FUNC'}
 {'is_defined': False, 'name': '_ZdaPvSt11align_val_t', 'type': 'FUNC'}
 {'is_defined': False, 'name': '_ZdlPv', 'type': 'FUNC'}
+{'is_defined': False, 'name': '_ZdlPvSt11align_val_t', 'type': 'FUNC'}
 {'is_defined': False, 'name': '_Znam', 'type': 'FUNC'}
 {'is_defined': False, 'name': '_ZnamSt11align_val_t', 'type': 'FUNC'}
----------------
curdeius wrote:
> abrachet wrote:
> > Still not sure why these are here though.
> It all depends on your environment and link flags. Once CI gets triggered you'd be able to get updated ABI lists from artifacts on failed build steps (in Buildkite). You'll **probably** need to remove these unrelated changes (exception, align_val_t).
How does CI get triggered for libcxx? You mentioned it in a previous comment, but will that be only after pushing the changes?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92790/new/

https://reviews.llvm.org/D92790