[libcxx-commits] [PATCH] D93071: [libc++] NFCI: Implement make_shared as allocate_shared with std::allocator

Marshall Clow via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Dec 10 15:25:45 PST 2020


mclow.lists added a comment.

In D93071#2447271 <https://reviews.llvm.org/D93071#2447271>, @mclow.lists wrote:

> if you allocate memory with an allocator, you need to deallocate it with the same allocator. Not with `operator delete`

There's a good chance that this is a pre-existing problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93071/new/

https://reviews.llvm.org/D93071



More information about the libcxx-commits mailing list