[libcxx-commits] [PATCH] D91140: [8/N] [libcxx] Fix the preexisting directory_iterator code for windows

Marek Kurdej via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Dec 10 14:11:19 PST 2020


curdeius added a comment.

Minor comment only. It would be cool to have the CI triggered...



================
Comment at: libcxx/src/filesystem/operations.cpp:325
+namespace {
+constexpr struct {
+  DWORD win;
----------------
You could use an inline variable instead of putting it into an anonymous namespace. Personally I find it cleaner.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91140/new/

https://reviews.llvm.org/D91140



More information about the libcxx-commits mailing list