[libcxx-commits] [PATCH] D88868: [M680x0] Add CycleTimer implementation for M68K architecture

Min-Yih Hsu via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Dec 10 08:07:02 PST 2020

myhsu added a comment.

In D88868#2445067 <https://reviews.llvm.org/D88868#2445067>, @RKSimon wrote:

> In D88868#2443692 <https://reviews.llvm.org/D88868#2443692>, @myhsu wrote:
>> In D88868#2442287 <https://reviews.llvm.org/D88868#2442287>, @lebedev.ri wrote:
>>> I don't believe this needs libc++'s signoff, it only mechanically replicates
>>> the exact same change to the same external dependency into all the duplicate copies of said dependency.
>>> @myhsu i still maintain that you can just commit this now.
>> As @ldionne mentioned libcxx was added automatically and I couldn't remove it. Otherwise I've already committed this patch a while ago: https://github.com/llvm/llvm-test-suite/commit/25883edc2f615a84c4fa741e997904293474bbc0
> Isn't that just testsuite's copy of the code from D89011 <https://reviews.llvm.org/D89011>? It looks like at least the libcxx parts of this patch still need committing.

You’re right, this a a different one. I’ll commit this shortly

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list