[libcxx-commits] [PATCH] D93025: [libc++] Remove invalid use of `#if _LIBCPP_STD_VER >= 11`, as `_LIBCPP_STD_VER` can never be less than 11.
Marek Kurdej via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Dec 10 06:46:31 PST 2020
curdeius planned changes to this revision.
curdeius added a comment.
In D93025#2445711 <https://reviews.llvm.org/D93025#2445711>, @mclow.lists wrote:
> if you need to remove something for C++03, then the test would be:
> `#ifndef _LIBCPP_CXX03_LANG`
That's exactly what I did in the first try. Please see diff https://reviews.llvm.org/D93025?id=310846.
But as one might have expected, there were tests already that depended on this (incorrect `#if`).
I'm still thinking what the best course of action should be.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits