[libcxx-commits] [PATCH] D92769: [libc++] [P1164] [C++20] Make fs::create_directory() error if there is already a non-directory.
Marek Kurdej via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Dec 10 04:43:01 PST 2020
curdeius added a comment.
In D92769#2444967 <https://reviews.llvm.org/D92769#2444967>, @mstorsjo wrote:
> Note that P1164 <https://reviews.llvm.org/P1164> talks about both `create_directory` and `create_directories`, while this fix only covers `create_directory`.
Indeed, but it doesn't change the behaviour of `create_directories` per se because it calls `create_directory` for every part of the path.
(Actually it changes a phrase from the "Returns" clause that was actually implying a contradiction on what should really be returned, but libc++ was doing already the right thing.)
Anyway, I'll add a test for `create_directories` in a follow-up patch.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits