[libcxx-commits] [PATCH] D91135: [3/N] [libcxx] Make filesystem::path::value_type wchar_t on windows

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/include/filesystem:1300
+      typename enable_if<is_same<_CharT, value_type>::value &&
                              is_same<_Traits, char_traits<char> >::value,
                          basic_ostream<_CharT, _Traits>&>::type
----------------
mstorsjo wrote:
> curdeius wrote:
> > Hmm?
> Right, this was a generalization from before I added the more windows specific bits, trying to move things to use explicitly `value_type` and `string_type` instead of hardcoding the types - but here it's a bit out of place, so I can drop these two changes from the patch.
Oh, sorry, I misread, now I see what you meant. Will fix.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91135/new/

https://reviews.llvm.org/D91135