[libcxx-commits] [PATCH] D91135: [3/N] [libcxx] Make filesystem::path::value_type wchar_t on windows

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Dec 9 13:13:44 PST 2020


mstorsjo added inline comments.


================
Comment at: libcxx/include/filesystem:579
+#ifndef _LIBCPP_NO_HAS_CHAR8_T
+typedef char8_t __u8_value;
+typedef u8string __u8_string;
----------------
curdeius wrote:
> Do you really need this type? Can't you use `__u8_string::value_type` instead?
I guess I can do that; this particular typedef goes away in one of the later patches anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91135/new/

https://reviews.llvm.org/D91135



More information about the libcxx-commits mailing list