[libcxx-commits] [PATCH] D92875: [libc++] Include C++ headers, not C headers, in <charconv>

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/include/charconv:429
     {
         if (__x <= __complement(__to_unsigned(__tl::min())))
         {
----------------
For the record: It might be nice if all of these function calls were also `_VSTD`-ed, but I decided that I didn't want to be that invasive right now. I am 99% confident that none of these function calls (including the memmove/memcpy ones that I //am// changing) can possibly be hijacked by ADL, because `to_chars` and `from_chars` are not templates and therefore no user-defined or even non-primitive types can possibly leak into these codepaths which are reachable only via the "bottleneck" of those non-template functions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92875/new/

https://reviews.llvm.org/D92875