[libcxx-commits] [PATCH] D92190: [libc++] fix std::sort(T**, T**)

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Dec 8 10:35:39 PST 2020


ldionne added a comment.

In D92190#2440545 <https://reviews.llvm.org/D92190#2440545>, @howard.hinnant wrote:

> Oh, yes, I believe that was it.  Just a code size optimization.

Thanks a lot, that confirms my hunch.

So @Quuxplusone feel free to investigate ways to remove or modify this, now that you know the original intent. We shouldn't take a code size regression for `constexpr`, though (I'm sure there's a bunch of ways we can make that work).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92190/new/

https://reviews.llvm.org/D92190



More information about the libcxx-commits mailing list