[libcxx-commits] [PATCH] D92856: [libc++] Use TARGET_FILE instead of TARGET_SONAME_FILE when generating ABI lists

[Louis Dionne via Phabricator via libcxx-commits]

ldionne created this revision.
Herald added subscribers: jkorous, mgorny.
ldionne requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

TARGET_SONAME_FILE isn't valid on Windows, and TARGET_FILE should achieve
the same results.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D92856

Files:
  libcxx/lib/abi/CMakeLists.txt


Index: libcxx/lib/abi/CMakeLists.txt
===================================================================
--- libcxx/lib/abi/CMakeLists.txt
+++ libcxx/lib/abi/CMakeLists.txt
@@ -57,7 +57,7 @@
       "${Python3_EXECUTABLE}" "${LIBCXX_SOURCE_DIR}/utils/sym_diff.py"
           --only-stdlib-symbols
           --strict "${abi_list_file}"
-          $<TARGET_SONAME_FILE:cxx_shared>
+          $<TARGET_FILE:tgt:cxx_shared>
       DEPENDS cxx_shared
       COMMENT "Testing libc++'s exported symbols against the ABI list")
   else()
@@ -67,7 +67,7 @@
   add_custom_target(generate-cxx-abilist
     COMMAND "${Python3_EXECUTABLE}" "${LIBCXX_SOURCE_DIR}/utils/generate_abi_list.py"
             --output "${abi_list_file}"
-            "$<TARGET_SONAME_FILE:cxx_shared>"
+            "$<TARGET_FILE:tgt:cxx_shared>"
     DEPENDS cxx_shared
     COMMENT "Generating the ABI list file for configuration ${abi_list_identifier}")
 else()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92856.310245.patch
Type: text/x-patch
Size: 928 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20201208/e79d8793/attachment.bin>