[libcxx-commits] [PATCH] D92814: [libc++] ADL-proof <iterator>. `__convert_to_integral` is not a customization point.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone created this revision.
Quuxplusone added a reviewer: ldionne.
Quuxplusone added a project: libc++.
Quuxplusone requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

The interesting change here is that we no longer consider `__convert_to_integral` an ADL customization point for the user's types. I think the new behavior is defensible. The old behavior had come from D7449 <https://reviews.llvm.org/D7449>, where Marshall explicitly said "people can't define their own [`__convert_to_integral` overloads]."


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D92814

Files:
  libcxx/include/algorithm
  libcxx/include/iterator
  libcxx/test/std/iterators/iterator.primitives/iterator.operations/robust_against_adl.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92814.310085.patch
Type: text/x-patch
Size: 4964 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20201208/9596654d/attachment.bin>