[libcxx-commits] [PATCH] D91173: [18/N] [libcxx] Use the posix code for directory_entry::__do_refresh
Martin Storsjö via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Dec 7 13:29:43 PST 2020
mstorsjo added a comment.
In D91173#2438006 <https://reviews.llvm.org/D91173#2438006>, @amccarth wrote:
> Oh, are there tests that need to be enabled on Windows?
There's a whole bunch of tests, and none of them are excluded on windows right now (as std::filesystem isn't possible to even build for windows as things are in git so far), so this patch reduces the amount of failing tests.
(Locally, I have a branch with a whole lot of patches on top of the testsuite for std::filesystem to disable/change bits to make it pass with MS STL, and with this patchset for the implementation in libc++, it gets to a point where the same tests that succeed with MS STL also succeed with libc++. I started out by upstreaming the least hacky bits of those patches, but there's just a whole lot of it, and it's more productive for now to focus on upstreaming the implementation. I was hoping for getting it in by the time of the llvm 12 branch, but we'll see how that goes...)
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits