[libcxx-commits] [PATCH] D92730: [libc++] [LWG3221] Add tests for wrapping operator+(year_month, months).

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/docs/Cxx2aStatusIssuesStatus.csv:171
 "`3222 <https://wg21.link/LWG3222>`__","P0574R1 introduced preconditions on non-existent parameters","Belfast","",""
-"`3221 <https://wg21.link/LWG3221>`__","Result of ``year_month``\  arithmetic with ``months``\  is ambiguous","Belfast","",""
+"`3221 <https://wg21.link/LWG3221>`__","Result of ``year_month``\  arithmetic with ``months``\  is ambiguous","Belfast","|Complete|","8.0"
 "`3235 <https://wg21.link/LWG3235>`__","``parse``\  manipulator without abbreviation is not callable","Belfast","",""
----------------
You checked the blame to figure out what version we shipped that in?


================
Comment at: libcxx/test/std/utilities/time/time.cal/time.cal.ym/time.cal.ym.nonmembers/plus.pass.cpp:38-52
+constexpr bool testConstexprYears(std::chrono::year_month ym) {
+  years offset{23};
+  assert(static_cast<int>((ym).year()) == 1);
+  assert(static_cast<int>((ym + offset).year()) == 24);
+  assert(static_cast<int>((offset + ym).year()) == 24);
+  return true;
+}
----------------
curdeius wrote:
> Actually I should get rid of these two, since I test the whole `test()` now in constexpr context. WDYT?
Agreed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92730/new/

https://reviews.llvm.org/D92730