[libcxx-commits] [PATCH] D92725: [libc++] [LWG2993] reference_wrapper<T> conversion from U&&

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/docs/Cxx2aStatusIssuesStatus.csv:38
 "`2988 <https://wg21.link/LWG2988>`__","Clause 32 cleanup missed one typename","Albuquerque","",""
-"`2993 <https://wg21.link/LWG2993>`__","reference_wrapper<T> conversion from T&&","Albuquerque","",""
+"`2993 <https://wg21.link/LWG2993>`__","reference_wrapper<T> conversion from T&&","Albuquerque","|Complete|",""
 "`2998 <https://wg21.link/LWG2998>`__","Requirements on function objects passed to {``forward_``,}list-specific algorithms","Albuquerque","|Nothing To Do|",""
----------------
Can you add the version number in the last column?



================
Comment at: libcxx/test/std/utilities/function.objects/refwrap/refwrap.const/deduct.pass.cpp:26
+    std::reference_wrapper rj(j);
+    static_assert(std::is_same<decltype(rj), std::reference_wrapper<const int>>::value, "");
+}
----------------
Since the test requires C++17 you could use `std::is_same_v` and remove the empty strings from the `static_assert`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92725/new/

https://reviews.llvm.org/D92725