[libcxx-commits] [PATCH] D92110: [SystemZ][ZOS] Provide PATH_MAX macro for libcxx

Hubert Tong via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Dec 4 12:20:37 PST 2020


hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.

Thanks; the targeted fix for handling `realpath` (where we have experimentally verified that the operation does fail with paths longer than 1024) seems reasonable to me. Looks good from my end.



================
Comment at: libcxx/src/filesystem/operations.cpp:545
+  #if defined(__MVS__)
+    char buff[1024 +1];
+  #else
----------------
Minor nit: style.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92110/new/

https://reviews.llvm.org/D92110



More information about the libcxx-commits mailing list