[libcxx-commits] [PATCH] D92255: [libc++] [P0202] constexpr set_union, set_difference, set_symmetric_difference, merge

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Dec 4 10:41:42 PST 2020

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

This LGTM if CI passes. However, since there's a bunch of stuff unrelated to the primary concern of the patch (which is to implement P0202), can you please split it up into separate commits? Ideally, those would have been separate reviews from the start to make it easier, but now the patch has been reviewed, so I guess there's no point in splitting it :-) For the commits, I suggest:

1. A NFC commit to update the synopsis of stuff that had gotten out of date
2. A commit to update includes.pass.cpp
3. A commit with the rest, which actually implements P0202

I won't bite if you want to land everything at once, though. I'm mostly trying to make an example to make sure we keep this in mind for future libc++ patches.

Also, I think we could improve the test coverage of all those algorithms by testing a wider array of inputs. I don't request that you do that, but if you do feel like doing it, the patch will be welcome. Thanks for the work!

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list