[libcxx-commits] [PATCH] D92656: [libc++] Add a script to automatize updating test for a new header.
Marek Kurdej via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Dec 4 09:53:51 PST 2020
curdeius added a comment.
I like your approach. It will indeed make it easier to add new tests and update current ones.
Comment at: libcxx/docs/Contributing.rst:29
+When adding or updating feature test macros, apart from modifying the ``include/version`` header, you should update the corresponding tests.
+To do that, modify ``feature_test_macros`` table in the script ``utils/generate_feature_test_macro_components.py``, run it, and commit updated files.
> That doesn't seem right -- you don't need to modify `<version>` yourself, the script does it. Am I misunderstanding what you meant here?
Oh, you're right. I thought it wasn't changing that.
Comment at: libcxx/docs/Contributing.rst:39
+2. Run ``python utils/generate_header_tests.py``, verify and commit the modifications.
+ The script updates the following test files to include the new header:
> I don't think it's necessary to keep the list of tests -- it'll only get out of date.
OK. Will remove.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits